Skip to content

fix: remove examples from welcome message #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

yueny2020
Copy link
Contributor

@yueny2020 yueny2020 commented Apr 22, 2025

Problem

  • remove examples from welcome message

Solution

before:
image

after change:
image

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yueny2020 yueny2020 requested a review from a team as a code owner April 22, 2025 05:35
@@ -84,23 +80,6 @@ export class TabFactory {
return tabData
}

private getWelcomeBlock() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC these are also enabled on agentic chat branch in VSCode, was there a requirement to remove them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description doesn't give any context why this change is made

Copy link
Contributor Author

@yueny2020 yueny2020 Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC these are also enabled on agentic chat branch in VSCode, was there a requirement to remove them?

yes, this is a task from the milestone tracker. https://quip-amazon.com/7X13ASYyYxww/VSC-IDE-2025-Milestones#temp:s:temp:C:CQC4e7b1709330f4137a05c2bf3f;temp:C:CQCdec271714ac84255a8f310a08

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be in conflict with the figma though? Can you raise this on the tiger team channel? I'm confused which ones the source of truth

the code itself looks fine though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed in team slack channel, this is a requirement from PM and the figma will be updated.

@yueny2020 yueny2020 requested a review from jpinkney-aws April 22, 2025 16:46
@jpinkney-aws jpinkney-aws merged commit 82138b3 into aws:main Apr 22, 2025
6 checks passed
@yueny2020 yueny2020 deleted the removebubble branch June 11, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants