feat(amazonq): initial UI for execute bash chat message #1041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-lee
approved these changes
Apr 22, 2025
| success: true, | ||
| } | ||
| } else { | ||
| return { success: false, failureReason: 'not implemented' } |
There was a problem hiding this comment.
Guessing this will be replaced soon
| ): Promise<ToolResult[]> { | ||
| const results: ToolResult[] = [] | ||
|
|
||
| for (const toolUse of toolUses) { | ||
| if (!toolUse.name || !toolUse.toolUseId) continue | ||
|
|
||
| let needsConfirmation |
There was a problem hiding this comment.
We might want this to be conditional on the tool type when we move towards granular permissions
kmile
approved these changes
Apr 22, 2025
jpinkney-aws
approved these changes
Apr 22, 2025
Hweinstock
reviewed
Apr 22, 2025
| // so the buttons are not in the window for the promise to be rejected/resolved | ||
| // this can to be brought back once intermediate messages are shown | ||
|
|
||
| // await deferred.promise |
There was a problem hiding this comment.
the client-side changes should be merged now. What other changes do we need before this can be enabled?
There was a problem hiding this comment.
this also needs improvement for intermediate chat result to show up
Hweinstock
approved these changes
Apr 22, 2025
This was referenced Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
remaining work:
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.