Skip to content

fix: added/deleted lines is incorrect #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

Conversation

ctlai95
Copy link
Contributor

@ctlai95 ctlai95 commented Apr 22, 2025

Problem

FsWrite card always shows +0 -0 for diff changes. This is happening because we aren't comparing with the old content before the tool executed.

Solution

  • Refactor fsWrite to move out all the logic relating to getting the contents before/after the change
  • Ensure we are always comparing with the old content (we are now storing this in a tool lookup map)
  • Fixed an issue where openDiff did not work for nested file paths because relative file path was not used
    image

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ctlai95 ctlai95 marked this pull request as ready for review April 22, 2025 08:59
@ctlai95 ctlai95 requested a review from a team as a code owner April 22, 2025 08:59
@ctlai95 ctlai95 merged commit 294bfec into aws:main Apr 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants