feat: workspace open settings #1055
Conversation
volodkevych
force-pushed
the
workspace-open-settings
branch
from
97c259a to
9eeb19a
Compare
| if (!localProjectContextController.isEnabled) { | ||
| // TODO: Prompt user to enable indexing | ||
| if (!localProjectContextController.isEnabled && chatResultStream) { | ||
| await chatResultStream.writeResultBlock({ |
There was a problem hiding this comment.
It feels a bit weird to stuff this message so deep in the triggerContext extracting utility. Given that we have access to context commands in params passed here and localProjectContextController in agenticChatController, this check for message could be done in agenticChatController itself
There was a problem hiding this comment.
I agree, but this code block depends on data parsed in this trigger context, so the simplest was to put it here. I could decouple it better, if I had more time.
There was a problem hiding this comment.
I approved, we can take it as a follow-up. I didn't see which parsed data it needs
There was a problem hiding this comment.
It depends on useRelevantDocuments, but yes, I will be doing another improvement, so can improve this one too.
Problem
There was no way to prompt customer to enable workspace indexing lib.
Solution
Show button to prompt customer to enable local workspace indexing.
Extension support of OPEN_SETTINGS is needed.
Screen.Recording.2025-04-22.at.18.48.47.mov
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.