feat: add cancellation handling to tools #1057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hweinstock
approved these changes
Apr 22, 2025
| @@ -554,6 +554,10 @@ export class AgenticChatController implements ChatHandlers { | |||
| break | |||
| } | |||
| } catch (err) { | |||
| if (CancellationError.isUserCancelled(err)) { | |||
There was a problem hiding this comment.
I handle tool validation rejections very similarly here. Do you think their logic should be combined more?
I think they should be separate since the stop button and the reject button are different, and could warrant different behavior in the future, but open to changing it.
There was a problem hiding this comment.
I think we should separate them since their intentions are different. I think they'd just have a minor overlap
server/aws-lsp-codewhisperer/src/language-server/agenticChat/tools/executeBash.ts
Show resolved
Hide resolved
Hweinstock
approved these changes
Apr 22, 2025
This was referenced Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
tools can't be canceled
Solution
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.