fix: update fsWrite toolSpec #1064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya169
approved these changes
Apr 22, 2025
ctlai95
approved these changes
Apr 22, 2025
jpinkney-aws
approved these changes
Apr 22, 2025
jguoamz
reviewed
Apr 22, 2025
| @@ -155,6 +155,8 @@ export class FsWrite { | |||
| and otherwise create a new file\n * The `append` command will add content to the end of an existing file, \ | |||
| automatically adding a newline if the file does not end with one. \ | |||
| The file must exist.\n Notes for using the `strReplace` command:\n * \ | |||
| IMPORTANT: For the `fsWrite` tool, only use the `strReplace` command for simple, isolated single-line replacements. \ | |||
There was a problem hiding this comment.
Remove "For the fsWrite too"
There was a problem hiding this comment.
Will modify in a follow-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
fsWritetool tends to favor doing line-by-line replaces which causesan increase in latency.
Solution
tool usage - restricting strReplace command to only simple single-line
replacements, while recommending the create command for multi-line
edits.:
* IMPORTANT: For thefsWritetool, only use thestrReplacecommand for simple, isolated single-line replacements. If you are editing multiple lines, always prefer thecreatecommand and replace the entire file content instead.Testing
Latency test results
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.