fix: ux polishing for read tool messages. #1070
Merged
+68
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmile
reviewed
Apr 22, 2025
Comment on lines
+44
to
+46
| getMessageIdToUpdate(): string | undefined { | ||
| return this.#state.messageIdToUpdate | ||
| } |
There was a problem hiding this comment.
Nit: if we add more message types, is this actually the 'read/query/search' message to update, and there might be others in the future?
There was a problem hiding this comment.
Yeah I agree
I am trying to use this same messageIdToUpdate for all the messages from read, list and grep(future). So we will be having only one messageId and can update all the messages contextList using this messageId.
Thats the plan if there are no challenges!
kmile
approved these changes
Apr 22, 2025
This was referenced Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
messageIdToUpdatestate to store the messageId and update this for next read tool messages.feature/agentic-chatbranch.TODO:
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.