feat(agentic chat): add permission check for all tools and add UI permission cards #1078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmile
approved these changes
Apr 23, 2025
kmile
reviewed
Apr 23, 2025
| const document = await this.#triggerContext.getTextDocument(input.path) | ||
| this.#triggerContext | ||
| .getToolUseLookup() | ||
| .set(toolUse.toolUseId, { ...toolUse, oldContent: document?.getText() }) |
There was a problem hiding this comment.
Are we taking a snapshot before showing the "allow writing outside workspace" message? Could this snapshot then be outdated by the time the file is actually modified?
There was a problem hiding this comment.
This was existing context used by writing code diffs. But yeah it is a possibility, in case of text changes during this period, tool use fails and model retries with updated file information
kmile
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
User permissions check for reading files/list directory outside of workspace is not setup.
Solution
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.