fix: remove undefined header from followup authenticate button #1085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya169
approved these changes
Apr 23, 2025
|
curious to see, how this empty header got introduced ?it was not there till yesterday |
viktorsaws
approved these changes
Apr 23, 2025
viktorsaws
approved these changes
Apr 23, 2025
This was referenced Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We were seeing empty yellow header on top of followup buttons, like "Authenticate"
Solution
Do not set header with empty properties.
Also fixed: TypeError: object is not iterable
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.