-
Notifications
You must be signed in to change notification settings - Fork 73
fix(chat-client): workspace checks for permission cards #1089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Hweinstock
merged 8 commits into
aws:main
from
ashishrp-aws:fix-workspace-permission-checks
Apr 23, 2025
Merged
fix(chat-client): workspace checks for permission cards #1089
Hweinstock
merged 8 commits into
aws:main
from
ashishrp-aws:fix-workspace-permission-checks
Apr 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hweinstock
reviewed
Apr 23, 2025
server/aws-lsp-codewhisperer/src/language-server/agenticChat/tools/fsRead.ts
Outdated
Show resolved
Hide resolved
server/aws-lsp-codewhisperer/src/language-server/agenticChat/tools/fsRead.ts
Outdated
Show resolved
Hide resolved
server/aws-lsp-codewhisperer/src/language-server/agenticChat/tools/fsWrite.ts
Outdated
Show resolved
Hide resolved
server/aws-lsp-codewhisperer/src/language-server/agenticChat/tools/listDirectory.ts
Outdated
Show resolved
Hide resolved
This test might also need to be updated. I believe it was relying on the old utility which is no longer used.
|
fixing test and corrected it for comments |
tsmithsz
approved these changes
Apr 23, 2025
Hweinstock
reviewed
Apr 23, 2025
server/aws-lsp-codewhisperer/src/language-server/agenticChat/tools/toolShared.ts
Outdated
Show resolved
Hide resolved
LGTM, will merge once CI passes. |
pras0131
reviewed
Apr 23, 2025
server/aws-lsp-codewhisperer/src/language-server/agenticChat/tools/fsWrite.ts
Outdated
Show resolved
Hide resolved
pras0131
reviewed
Apr 23, 2025
server/aws-lsp-codewhisperer/src/language-server/agenticChat/tools/toolShared.ts
Outdated
Show resolved
Hide resolved
Hweinstock
approved these changes
Apr 23, 2025
This was referenced Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Permission check cards are appearing for all the files inside workspace. This is happening due to regresion in workspace.getTextDocument failure which works only for open documents on editor.
Solution
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.