fix: add formatChatHistoryMessage to chatDb #1110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Code on Agentic Chat
https://github.com/aws/aws-toolkit-vscode/blob/feature/agentic-chat/packages/core/src/shared/db/chatDb/chatDb.ts#L298
Problem
We only need the toolResult in the userMessageContext. This is causing validation exceptions as we are not taking the other fields into account when calculating the character count in the history and are hence not getting an accurate figure for the history length. As a result, we think the history is valid.
Solution
Only store the toolResult in userMessageContext
Testing
Verified that the history file now only stores toolResult in userMessageContext:
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.