Skip to content

fix: update pp mode in tab store #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged

fix: update pp mode in tab store #1128

merged 1 commit into from
Apr 25, 2025

Conversation

yueny2020
Copy link
Contributor

Problem

  • update pp mode in tab store

Solution

  • The pp mode is per tab and every time the pp mode change needs to update the tab store. Then use the pp mode in tab store for ui display.

Test

Before change: the pp mode is cross tab and doesn't align with the pp mode toggle button.
  • In Tab1, the pp mode = off. Then click add new tab button, the Tab2 was created with pp mode = on, but the code block still showed insert-to-cursor.

Tab1:
image
Tab2:
image

After change: the pp mode is per tab and align with the pp mode toggle button.
  • In Tab1, the pp mode = off. Then click add new tab button, the Tab2 was created with pp mode = on, but the code block did NOT showed insert-to-cursor.

Tab1:
image
Tab2
image

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yueny2020 yueny2020 requested a review from a team as a code owner April 25, 2025 01:45
Copy link
Contributor

@laileni-aws laileni-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
For context pp = pair programming mode.

@yueny2020 yueny2020 merged commit 7c5e5a8 into aws:main Apr 25, 2025
6 checks passed
@yueny2020 yueny2020 deleted the ppstore branch June 11, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants