fix: make LLM less apologetic, increase listDirectory result size #1242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpinkney-aws
approved these changes
May 2, 2025
ctlai95
reviewed
May 2, 2025
| if (toolResult.status === ToolResultStatus.ERROR) { | ||
| for (const content of toolResult.content ?? []) { | ||
| if (content.json && JSON.stringify(content.json).includes(outputLimitExceedsPartialMsg)) { | ||
| // do not send the content response back for this case to avoid unnecessary messages |
There was a problem hiding this comment.
I think this could result in the duplicate explanation issue again
There was a problem hiding this comment.
it shouldn't, this only happens for when result is too large
This was referenced May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.