Skip to content

fix: emit all errors to get total # of errors #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025
Merged

Conversation

chungjac
Copy link
Contributor

@chungjac chungjac commented May 2, 2025

Problem

  • Previously, error metrics were only emitted when the backend returned a status code. However, mid-stream exceptions, which we now log the request IDs, lack status codes, causing these error metrics to not be emitted

Solution

  • Extended error metric emission to include cases without status codes For unactionable errors, such as user-dependent errors like PromptCharacterLimit, we will emit a custom message so we can query in kibana. This ensures we capture all relevant error states for monitoring and debugging.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chungjac chungjac marked this pull request as ready for review May 2, 2025 23:17
@chungjac chungjac requested a review from a team as a code owner May 2, 2025 23:17
@chungjac chungjac force-pushed the emit-error branch 3 times, most recently from 6a9f5c7 to b957895 Compare May 2, 2025 23:38
@chungjac chungjac force-pushed the emit-error branch 2 times, most recently from 0154cbc to f0b3045 Compare May 5, 2025 18:03
@chungjac chungjac changed the title fix: emit error metric without needing status code fix: emit all errors to get total # of errors May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants