fix: prevent uglifying class and function names when bundling codewhisperer #909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 3, 2025 17:24
rahmaniaam
approved these changes
Apr 7, 2025
added 3 commits
April 7, 2025 14:58
…es-codewhisperer-bundling
…es-codewhisperer-bundling
…es-codewhisperer-bundling
pras0131
approved these changes
Apr 16, 2025
added 2 commits
April 17, 2025 14:49
pras0131
approved these changes
Apr 17, 2025
francescoopiccoli
deleted the
frapicc/prevent-uglifying-class-function-names-codewhisperer-bundling
branch
nborges-aws
pushed a commit
that referenced
this pull request
Apr 17, 2025
…ing when bundled (#909) * fix: prevent uglifying class and function names when bundling codewhisperer * chore: fix format * fix: add missing import * feat: log class name from language servers (not from runtimes) * fix: log directly hardcoded class name, undo keep class and file names * fix: merge conflicts + updated logging after merge * feat: add hardcoded logging for new iam streaming client --------- Co-authored-by: Francesco Piccoli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When running bundled codewhisperer server, the webpack bundling uglifies/minimizes class names, hence making the logs of certain class/function names not recognizable.
To reproduce this try running
CodeWhisperer Server Tokendebug config and check theAWS Document Language Servertab logs, you can see something like "Configured AWS SDK V3 Proxy for Po".Solution
Directly hard code class names for logging from language servers, avoid logging class name from runtimes.
Related PR in runtimes: aws/language-server-runtimes#412
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.