Skip to content

feat: handle fileClick events #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged

Conversation

vidkhath
Copy link
Contributor

@vidkhath vidkhath commented Apr 7, 2025

Problem

Handle file click events in chat client to support file click for context transparency.

Solution

image

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vidkhath vidkhath requested a review from a team as a code owner April 7, 2025 15:25
@@ -165,4 +168,9 @@ export class Messager {
onCreatePrompt = (promptName: string): void => {
this.chatApi.createPrompt({ promptName })
}

onFileClick = (params: FileClickParams): void => {
this.chatApi.telemetry({ ...params, name: FILE_CLICK_TELEMETRY_EVENT })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also have telemetry for this on vscode side?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If no, we should double-check if it's really needed.

@vidkhath vidkhath merged commit 511be2e into main Apr 8, 2025
6 checks passed
@vidkhath vidkhath deleted the vidkhath/context-transparency branch April 8, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants