feat: port readDirectoryRecursively from VSC #923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmile
reviewed
Apr 8, 2025
Comment on lines
+22
to
+27
| testFeatures.workspace.fs.readdir = path => fs.readdir(path, { withFileTypes: true }) | ||
| testFeatures.workspace.fs.exists = path => | ||
| fs.access(path).then( | ||
| () => true, | ||
| () => false | ||
| ) |
There was a problem hiding this comment.
TestFeatures already provides stubs for all namespaces, so this should technically not be necessary. Unless you want to 'undo' the stubbing and go back to the real filesystem.
There was a problem hiding this comment.
Looking at the rest of the test, it's indeed easier just to defer to the actual filesystem than to stub out a bunch of recursive / nested calls to TestFeatures. 👍
There was a problem hiding this comment.
Yeah I am intending to 'undo' the stubbing here, but most ways felt pretty awkward. This is the best solution I came up with, but lmk if you see a better option.
kmile
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This utility function is needed for the agentic tools and currently lives in the VSC repo.
Solution
Notes
This PR contains some workarounds with TODO comments that can be properly addressed by aws/language-server-runtimes#415.
This same PR will also fix the warning on newer versions of node:
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.