feat: add proper windows support for executeBash and remove mocks in tests. #934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hweinstock
changed the title
justinmk3
approved these changes
Apr 9, 2025
Hweinstock
changed the title
kmile
approved these changes
Apr 11, 2025
kmile
reviewed
Apr 11, 2025
| @@ -220,6 +220,7 @@ export class ExecuteBash { | |||
|
|
|||
| let firstChunk = true | |||
| let firstStderrChunk = true | |||
| const writer = updates?.getWriter() | |||
There was a problem hiding this comment.
Where is this writer used? If it's used to communicate updates to the client then we might want to initialize the tool with a more comprehensive abstraction (I'm not saying tossing Features into it, but maybe something more explicit than an any stream?)
There was a problem hiding this comment.
I believe it is used to pipe the stdout and stderr streams into the chat from the ChildProcess.
Yes, I agree an abstraction would be helpful. This is the equivalent of that on the VSC side, but this will likely have to be rewritten to properly interface with Flare's chat interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The tests for executeBash currently mock the underlying process providing little confidence the flow works properly, as child processes can behave in unexpected ways on different OS.
After removing the mocks for executeBash the tests still pass on windows. I suspect this is because Git for Windows includes Git Bash which includes
whichand other unix utilities. However, this may not be the case on customer machines.Solution
whereinstead since Node spawned processes default to command prompt, which supportswhereby default.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.