feat: expose configuration for GPU acceleration and index worker threads in context server #960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ads in context server
kmile
reviewed
Apr 17, 2025
Comment on lines
121
to
126
| updatedConfig.projectContext?.enableLocalIndexing | ||
| ? await localProjectContextController.init() | ||
| ? await localProjectContextController.init({ | ||
| enableGpuAcceleration: updatedConfig?.projectContext?.enableGpuAcceleration, | ||
| indexWorkerThreads: updatedConfig?.projectContext?.indexWorkerThreads, | ||
| }) | ||
| : await localProjectContextController.dispose() |
There was a problem hiding this comment.
At this point should this just be an if statement? ;)
kmile
reviewed
Apr 17, 2025
Comment on lines
121
to
126
| updatedConfig.projectContext?.enableLocalIndexing | ||
| ? await localProjectContextController.init() | ||
| ? await localProjectContextController.init({ | ||
| enableGpuAcceleration: updatedConfig?.projectContext?.enableGpuAcceleration, | ||
| indexWorkerThreads: updatedConfig?.projectContext?.indexWorkerThreads, | ||
| }) | ||
| : await localProjectContextController.dispose() |
There was a problem hiding this comment.
Can init and dispose be done multiple times per session? What happens if (for whatever reason) 2 inits or 2 disposes happen in a row?
There was a problem hiding this comment.
Reading along, it seems like 2x dispose is pretty safe, but 2x init would result in orphaned resources.
There was a problem hiding this comment.
Made init no-op if already initialized.
kmile
reviewed
Apr 17, 2025
| @@ -112,6 +114,8 @@ export async function getAmazonQRelatedWorkspaceConfigs( | |||
| }, | |||
| projectContext: { | |||
| enableLocalIndexing: newQConfig.projectContext?.enableLocalIndexing === true, | |||
| enableGpuAcceleration: newQConfig.projectContext?.enableGpuAcceleration === true, | |||
| indexWorkerThreads: newQConfig.projectContext?.indexWorkerThreads ?? -1, | |||
There was a problem hiding this comment.
Does -1 have a special meaning? Or would 0 threads mean the same thing?
There was a problem hiding this comment.
It would be the same - I just considered -1 to be more of an effective no-op/disabled state.
kmile
approved these changes
Apr 17, 2025
breedloj
force-pushed
the
additionalContextOptions
branch
3 times, most recently
from
bb3ce8a to
911e441
Compare
breedloj
force-pushed
the
additionalContextOptions
branch
from
911e441 to
12ae8c7
Compare
kmile
approved these changes
Apr 21, 2025
This was referenced Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Clients may want to configure the optional GPU acceleration and index worker thread parameters of the local indexing library. VSCode and Jetbrains support these options in their user facing preference panes.
Solution
Add these options to the LSP server's supported set of configurables. By default, GPU acceleration is off and index worker threads are not explicitly set.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.