fix(chat-client): disable click event for empty history list item #973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktorsaws
commented
Apr 16, 2025
| @@ -20,6 +20,8 @@ import { Features } from '@aws/language-server-runtimes/server-interface/server' | |||
| import { ConversationItemGroup } from '@aws/language-server-runtimes/protocol' | |||
| import { getUserHomeDir } from '@aws/lsp-core/out/util/path' | |||
|
|
|||
| export const EMPTY_CONVERSATION_LIST_ID = 'empty' | |||
There was a problem hiding this comment.
We could move empty key to types package to properly share it between Chat Client and language server.
There was a problem hiding this comment.
Or we could introduce isClickable property on item level to decouple a bit.
volodkevych
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Click on empty history list item open chat window and sends
conversationClickedevent to language server.Solution
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.