fix: temporary fix for error where undefined is being passed to path.… #980
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Trying to run the built artifacts gives the following error:
This is happening due to changes introduced in: #949
This line in particular is the root cause:
path.join(dirname(require.main!.filename), 'indexing')
require.main
returns undefined so the!
assertion is a naive assertion here. And when path.join tries to joinundefined
withindexing
it fails becausepath.join
doesn't acceptundefined
Solution
As a temporary fix, I have removed the problematic line and replaced it with a hardcoded value. I will let @breedloj know about this and discuss details
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.