fix: handle indexing library import when require.main is undefined #982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nborges-aws
approved these changes
Apr 16, 2025
volodkevych
reviewed
Apr 17, 2025
server/aws-lsp-codewhisperer/src/shared/localProjectContextController.ts
Show resolved
Hide resolved
volodkevych
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
require.mainmay be undefined in cases such as the Webpack build process. This previously would have resulted in an exception.Solution
Handling for case where
require.mainis undefined, with fallback attempt being made to resolve off__dirnameto discover the import. Ultimately if the library cannot be found indexing will not be available but will not break other LSP functionality.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.