Skip to content

Commit 664bf78

Browse files
ammarfaizi2axboe
authored andcommitted
test/Makefile: Append -lpthread to LDFLAGS for all tests
Instead of overriding LDFLAGS one by one for tests that need pthread, append -lpthread to LDFLAGS for all tests. This makes the Makefile script simpler. It also saves some hassle when we add a new test that does use pthread. Signed-off-by: Ammar Faizi <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jens Axboe <[email protected]>
1 parent 20b5eda commit 664bf78

File tree

1 file changed

+1
-23
lines changed

1 file changed

+1
-23
lines changed

test/Makefile

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ override CFLAGS += $(XCFLAGS) -DLIBURING_BUILD_TEST
3131
override CXXFLAGS += $(XCFLAGS) -std=c++11 -DLIBURING_BUILD_TEST
3232

3333
LDFLAGS ?=
34-
override LDFLAGS += -L../src/ -luring
34+
override LDFLAGS += -L../src/ -luring -lpthread
3535

3636
test_srcs := \
3737
232c93d07b74.c \
@@ -211,28 +211,6 @@ helpers.o: helpers.c
211211
$(QUIET_CXX)$(CXX) $(CPPFLAGS) $(CXXFLAGS) -o $@ $< $(helpers) $(LDFLAGS)
212212

213213

214-
35fa71a030ca: override LDFLAGS += -lpthread
215-
232c93d07b74: override LDFLAGS += -lpthread
216-
send_recv: override LDFLAGS += -lpthread
217-
send_recvmsg: override LDFLAGS += -lpthread
218-
poll-link: override LDFLAGS += -lpthread
219-
accept-link: override LDFLAGS += -lpthread
220-
submit-reuse: override LDFLAGS += -lpthread
221-
poll-v-poll: override LDFLAGS += -lpthread
222-
across-fork: override LDFLAGS += -lpthread
223-
ce593a6c480a: override LDFLAGS += -lpthread
224-
wakeup-hang: override LDFLAGS += -lpthread
225-
pipe-eof: override LDFLAGS += -lpthread
226-
timeout-new: override LDFLAGS += -lpthread
227-
thread-exit: override LDFLAGS += -lpthread
228-
ring-leak2: override LDFLAGS += -lpthread
229-
poll-mshot-update: override LDFLAGS += -lpthread
230-
exit-no-cleanup: override LDFLAGS += -lpthread
231-
pollfree: override LDFLAGS += -lpthread
232-
msg-ring: override LDFLAGS += -lpthread
233-
recv-msgall: override LDFLAGS += -lpthread
234-
recv-msgall-stream: override LDFLAGS += -lpthread
235-
236214
install: $(test_targets) runtests.sh runtests-loop.sh
237215
$(INSTALL) -D -d -m 755 $(datadir)/liburing-test/
238216
$(INSTALL) -D -m 755 $(test_targets) $(datadir)/liburing-test/

0 commit comments

Comments
 (0)