Skip to content

Update flymake -error, -warning, and -note to match flycheck #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

krzysz00
Copy link
Contributor

@krzysz00 krzysz00 commented Feb 9, 2025

This commit updates the faces for Flymake's reported errors, warnings, and notes to make them more visible in non-GUI environments.

The faces were copied from their flycheck counterparts for consistency.

Before
flymake-error-warning-before

After
flymake-error-warning-after

Screenshots from a 24-bit true-color terminal


Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • You've added a before/after screenshot illustrating visually your changes.
  • You've updated the readme (if adding/changing configuration options) (N/A)

Thanks!

This commit updates the faces for Flymake's reported errors, warnings,
and notes to make them more visible in non-GUI environments.
@bbatsov bbatsov merged commit ac09b78 into bbatsov:master Feb 9, 2025
@bbatsov
Copy link
Owner

bbatsov commented Feb 9, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants