Feature/sem ex improvements (eclipse-esmf#132)

* Remove outdated code

* Minor code clean-up

* Correct adding date filter at *-FilterService

* Fix date range filter format at *-FilterService

Author: sha4be

Diff for: src/ng-generate/components/shared/generators/services/filter/files/__name@dasherize__-filter.service.ts.template

@@ -320,7 +320,7 @@ export class <%= classify(name) %>FilterService {
         <% } %>
 
         private createDateAsUTC(date: Date) {
-            return new Date(Date.UTC(date.getFullYear(), date.getMonth(), date.getDate(), date.getHours(), date.getMinutes(), date.getSeconds()));
+            return new Date(Date.UTC(date.getFullYear(), date.getMonth(), date.getDate(), date.getHours(), date.getMinutes(), date.getSeconds(), date.getMilliseconds()));
         }
 
         private getFormattedDate(theDate: string) {

Diff for: src/ng-generate/components/shared/generators/services/filter/index.ts

@@ -274,7 +274,10 @@ const getChipLabelEnum = (filterProp: PropValue) => {
 
 function getDateRemote(values: PropValue[]): string {
     const template = (value: any) => ` 
-        this.applyFilterForTime(query, '${value.propertyName}');
+        if(this.${value.propertyName}Group.valid) {
+            const {fromControl, toControl} = this.${value.propertyName}Group.value;
+            this.applySingleDateFilter(query, fromControl, toControl, '${value.propertyName}');
+        }
     `;
 
     const activeFilters = values.map(template).join('');
@@ -284,61 +287,54 @@ function getDateRemote(values: PropValue[]): string {
             ${activeFilters}
         }
         
-        applyFilterForTime(query: AbstractLogicalNode, timeType: string): void {
+        private applySingleDateFilter(query: AbstractLogicalNode, from: number, to: number, filterPropName: string): void {
             const conditions = [];
-            const group = (this as any)[\`\${timeType}Group\`];
-            
-            if (group.invalid) {
-                return;
-            }
-            
-            const {fromControl, toControl} = group.value;
-
-            const startDateUTC: string | null = fromControl ? this.createDateAsUTC(new Date(fromControl)).toISOString() : null;
-            let endDateUTC: Date | null = toControl ? this.createDateAsUTC(new Date(toControl)) : null;
+    
+            const fromDateUTC: string | null = from ? this.createDateAsUTC(new Date(from)).toISOString() : null;
+            let toDateUTC: string | null = null;
+            let toDate: Date | null = to ? this.createDateAsUTC(new Date(to)) : null;
         
-            if (endDateUTC) {
-              endDateUTC = new Date(endDateUTC.setHours(23, 59, 59, 999));
+            if (toDate) {
+                toDateUTC = this.createDateAsUTC(new Date(toDate.setHours(23, 59, 59, 999))).toISOString();
             }
         
-            if (startDateUTC) {
-              conditions.push(new Ge(timeType, \`\${startDateUTC}\`));
+            if (fromDateUTC) {
+                conditions.push(new Ge(filterPropName, fromDateUTC));
             }
-            if (endDateUTC) {
-              conditions.push(new Le(timeType, \`\${endDateUTC.toISOString()}\`));
+            if (toDateUTC) {
+                conditions.push(new Le(filterPropName, toDateUTC));
             }
             if (conditions.length > 0) {
-              query.addNode(conditions.length > 1 ? new And(conditions) : conditions[0]);
+                query.addNode(conditions.length > 1 ? new And(conditions) : conditions[0]);
             }
-
-            let label = this.translateService.translate(\`${sharedOptions.translationPath}\${timeType}.preferredName\`);
-
-            if (startDateUTC && endDateUTC) {
-              label += \`: \${this.getFormattedDate(startDateUTC)} - \${this.getFormattedDate(endDateUTC.toISOString())}\`;
-              this.updateActiveFilters(timeType, label);
-            } else if (endDateUTC) {
-              label += \`: to \${this.getFormattedDate(endDateUTC.toISOString())}\`;
-              this.updateActiveFilters(timeType, label);
-            } else if (startDateUTC) {
-              label += \`: from \${this.getFormattedDate(startDateUTC)}\`;
-              this.updateActiveFilters(timeType, label);
-            }
-        }
         
-        updateActiveFilters(prop: string, label: string) {
-            const filter = this.activeFilters.find(af => af.prop === prop);
-            if (!filter) {
-              this.activeFilters.push(<FilterType>{
-                removable: true,
-                type: FilterEnums.Date,
-                label: label,
-                prop: prop
-              });
-            } else {
-              filter.label = label;
+            // DCV-SPECIFIC: wrap the rest of the code in if condition to avoid chip list not updating or removing
+            if (fromDateUTC || toDateUTC) {
+                const filterIndex = this.activeFilters.findIndex(af => af.prop === filterPropName);
+        
+                let label = this.translateService.translate('batch.v030.' + filterPropName + '.preferredName');
+        
+                if (fromDateUTC && toDateUTC) {
+                    label += ' ' + this.getFormattedDate(fromDateUTC) + ' - ' + this.getFormattedDate(toDate.toISOString());
+                } else if (toDateUTC) {
+                    label += ' to ' + this.getFormattedDate(toDate.toISOString());
+                } else if (fromDateUTC) {
+                    label += ' from ' + this.getFormattedDate(fromDateUTC);
+                }
+        
+                if (filterIndex === -1) {
+                    this.activeFilters.push({
+                        removable: true,
+                        type: FilterEnums.Date,
+                        label,
+                        prop: filterPropName
+                    });
+                } else {
+                    this.activeFilters[filterIndex].label = label;
+                }
             }
-        }
-    `;
+      }
+`;
 }
 
 function getDateNotRemote(values: PropValue[]): string {

Diff for: src/ng-generate/components/shared/methods/remote-handling/requestData.ts.template

@@ -109,10 +109,8 @@ private requestData() {
             catchError((error: any) => {
                 this.dataLoadError = false;
                 <% if (options.componentType === 'card') { %>
-                    this.dataToShow = [];
-                    this.dataSource.data = [];
+                    this.dataSource.setData([]);
                 <% } else { %>
-                    const dataToShow = [];
                     this.dataSource.setData([]);
                 <% } %>
 

Diff for: src/ng-generate/components/table/generators/components/table/files/__name@dasherize__.component.ts.template

@@ -677,13 +677,15 @@ export class <%= classify(name) %>Component implements OnInit, AfterViewInit, Af
         }
     <% } %>
 
-    protected isAvailableRowAction(action: RowAction, rowData: <%= options.aspectModelTypeName %>): boolean {
-        if (!this.actionResolvers || !this.actionResolvers[action]) {
-            return true;
-        }
+    <% if (hasCustomRowActions) { %>
+        protected isAvailableRowAction(action: RowAction, rowData: <%= options.aspectModelTypeName %>): boolean {
+            if (!this.actionResolvers || !this.actionResolvers[action]) {
+                return true;
+            }
 
-        return this.actionResolvers[action](rowData) ?? true;
-    }
+            return this.actionResolvers[action](rowData) ?? true;
+        }
+    <% } %>
 
     <% if (options.hasSearchBar) { %>
         private initializeHighlightConfig(): void {