Skip to content

Commit dd408d8

Browse files
cipolleschibillnbell3
cipolleschi
authored and
billnbell3
committed
Remove StaticFrameworks jobs (facebook#38551)
Summary: Pull Request resolved: facebook#38551 I think we can safely remove the StaticFrameworks tests: the DynamicFrameworks are stricter than the static, so if something works in a dynamic frameworks setup, it will work also in the static framework one. we can safely delete the following tests - test_ios_template-NewArch-Debug-WithoutFlipper-Hermes-StaticFrameworks - test_ios_template-NewArch-Debug-WithoutFlipper-JSC-StaticFrameworks - test_ios_template-NewArch-Release-WithoutFlipper-Hermes-StaticFrameworks - test_ios_template-NewArch-Release-WithoutFlipper-JSC-StaticFrameworks - test_ios_template-OldArch-Debug-WithoutFlipper-Hermes-StaticFrameworks - test_ios_template-OldArch-Debug-WithoutFlipper-JSC-StaticFrameworks - test_ios_template-OldArch-Release-WithoutFlipper-Hermes-StaticFrameworks - test_ios_template-OldArch-Release-WithoutFlipper-JSC-StaticFrameworks - test_ios_rntester-NewArch-Hermes-StaticFrameworks - test_ios_rntester-NewArch-JSC-StaticFrameworks - test_ios_rntester-OldArch-Hermes-StaticFrameworks - test_ios_rntester-OldArch-JSC-StaticFrameworks ## Changelog [Internal] - Remove static frameworks tests in CircleCI Reviewed By: dmytrorykun Differential Revision: D47669902 fbshipit-source-id: 4888bbf88bb23284e410936910e5f71c969408d0
1 parent 995f3b2 commit dd408d8

File tree

1 file changed

+7
-54
lines changed

1 file changed

+7
-54
lines changed

‎.circleci/config.yml

Lines changed: 7 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ commands:
259259
command: cp packages/rn-tester/Podfile.lock packages/rn-tester/Podfile.lock.bak
260260
- restore_cache:
261261
keys:
262-
# The committed lockfile is generated using USE_FRAMEWORKS=0 and USE_HERMES=1 so it could load an outdated cache if a change
262+
# The committed lockfile is generated using static libraries and USE_HERMES=1 so it could load an outdated cache if a change
263263
# only affects the frameworks or hermes config. To help prevent this also cache based on the content of Podfile.
264264
- *pods_cache_key
265265
- steps: << parameters.steps >>
@@ -847,7 +847,7 @@ jobs:
847847
default: "StaticLibraries"
848848
description: Which kind of option we want to use for `use_frameworks!`
849849
type: enum
850-
enum: ["StaticLibraries", "StaticFrameworks", "DynamicFrameworks"]
850+
enum: ["StaticLibraries", "DynamicFrameworks"]
851851
ruby_version:
852852
default: "2.6.10"
853853
description: The version of ruby that must be used
@@ -898,9 +898,7 @@ jobs:
898898
export NO_FLIPPER=1
899899
fi
900900
901-
if [[ << parameters.use_frameworks >> == "StaticFrameworks" ]]; then
902-
export USE_FRAMEWORKS=static
903-
elif [[ << parameters.use_frameworks >> == "DynamicFrameworks" ]]; then
901+
if [[ << parameters.use_frameworks >> == "DynamicFrameworks" ]]; then
904902
export USE_FRAMEWORKS=dynamic
905903
fi
906904
@@ -960,9 +958,9 @@ jobs:
960958
enum: ["NewArch", "OldArch"]
961959
use_frameworks:
962960
default: "StaticLibraries"
963-
description: The dependency building and linking strategy to use. Must be one of "StaticLibraries", "StaticFrameworks", "DynamicFrameworks"
961+
description: The dependency building and linking strategy to use. Must be one of "StaticLibraries", "DynamicFrameworks"
964962
type: enum
965-
enum: ["StaticLibraries", "StaticFrameworks", "DynamicFrameworks"]
963+
enum: ["StaticLibraries", "DynamicFrameworks"]
966964
ruby_version:
967965
default: "2.6.10"
968966
description: The version of ruby that must be used
@@ -997,11 +995,6 @@ jobs:
997995
export USE_HERMES=0
998996
fi
999997
1000-
if [[ << parameters.use_frameworks >> == "StaticFrameworks" ]]; then
1001-
export NO_FLIPPER=1
1002-
export USE_FRAMEWORKS=static
1003-
fi
1004-
1005998
if [[ << parameters.use_frameworks >> == "DynamicFrameworks" ]]; then
1006999
export NO_FLIPPER=1
10071000
export USE_FRAMEWORKS=dynamic
@@ -1684,18 +1677,13 @@ workflows:
16841677
flavor: ["Debug", "Release"]
16851678
jsengine: ["Hermes", "JSC"]
16861679
flipper: ["WithFlipper", "WithoutFlipper"]
1687-
use_frameworks: ["StaticLibraries", "StaticFrameworks", "DynamicFrameworks"]
1680+
use_frameworks: ["StaticLibraries", "DynamicFrameworks"]
16881681
exclude:
16891682
- architecture: "NewArch"
16901683
flavor: "Release"
16911684
jsengine: "Hermes"
16921685
flipper: "WithFlipper"
16931686
use_frameworks: "StaticLibraries"
1694-
- architecture: "NewArch"
1695-
flavor: "Release"
1696-
jsengine: "Hermes"
1697-
flipper: "WithFlipper"
1698-
use_frameworks: "StaticFrameworks"
16991687
- architecture: "NewArch"
17001688
flavor: "Release"
17011689
jsengine: "Hermes"
@@ -1706,11 +1694,6 @@ workflows:
17061694
jsengine: "JSC"
17071695
flipper: "WithFlipper"
17081696
use_frameworks: "StaticLibraries"
1709-
- architecture: "NewArch"
1710-
flavor: "Release"
1711-
jsengine: "JSC"
1712-
flipper: "WithFlipper"
1713-
use_frameworks: "StaticFrameworks"
17141697
- architecture: "NewArch"
17151698
flavor: "Release"
17161699
jsengine: "JSC"
@@ -1721,11 +1704,6 @@ workflows:
17211704
jsengine: "Hermes"
17221705
flipper: "WithFlipper"
17231706
use_frameworks: "StaticLibraries"
1724-
- architecture: "OldArch"
1725-
flavor: "Release"
1726-
jsengine: "Hermes"
1727-
flipper: "WithFlipper"
1728-
use_frameworks: "StaticFrameworks"
17291707
- architecture: "OldArch"
17301708
flavor: "Release"
17311709
jsengine: "Hermes"
@@ -1736,36 +1714,11 @@ workflows:
17361714
jsengine: "JSC"
17371715
flipper: "WithFlipper"
17381716
use_frameworks: "StaticLibraries"
1739-
- architecture: "OldArch"
1740-
flavor: "Release"
1741-
jsengine: "JSC"
1742-
flipper: "WithFlipper"
1743-
use_frameworks: "StaticFrameworks"
17441717
- architecture: "OldArch"
17451718
flavor: "Release"
17461719
jsengine: "JSC"
17471720
flipper: "WithFlipper"
17481721
use_frameworks: "DynamicFrameworks"
1749-
- architecture: "NewArch"
1750-
flavor: "Debug"
1751-
jsengine: "Hermes"
1752-
flipper: "WithFlipper"
1753-
use_frameworks: "StaticFrameworks"
1754-
- architecture: "NewArch"
1755-
flavor: "Debug"
1756-
jsengine: "JSC"
1757-
flipper: "WithFlipper"
1758-
use_frameworks: "StaticFrameworks"
1759-
- architecture: "OldArch"
1760-
flavor: "Debug"
1761-
jsengine: "Hermes"
1762-
flipper: "WithFlipper"
1763-
use_frameworks: "StaticFrameworks"
1764-
- architecture: "OldArch"
1765-
flavor: "Debug"
1766-
jsengine: "JSC"
1767-
flipper: "WithFlipper"
1768-
use_frameworks: "StaticFrameworks"
17691722
- architecture: "NewArch"
17701723
flavor: "Debug"
17711724
jsengine: "Hermes"
@@ -1805,7 +1758,7 @@ workflows:
18051758
parameters:
18061759
architecture: ["NewArch", "OldArch"]
18071760
jsengine: ["Hermes", "JSC"]
1808-
use_frameworks: ["StaticLibraries", "StaticFrameworks", "DynamicFrameworks"]
1761+
use_frameworks: ["StaticLibraries", "DynamicFrameworks"]
18091762
- test_ios:
18101763
name: "Test iOS with Ruby 2.7.7"
18111764
run_unit_tests: true

0 commit comments

Comments
 (0)