Skip to content

Commit ded2bca

Browse files
szymonrybczakbillnbell3
authored andcommitted
Bump NDK to 25 (facebook#37974)
Summary: Bumps NDK to current LTS Release. ## Changelog: [Android] [Changed] - Bump NDK to 25 Pull Request resolved: facebook#37974 Test Plan: CI Green ✅ Reviewed By: christophpurrer Differential Revision: D47754763 Pulled By: cortinico fbshipit-source-id: 24fbca503b3814c28a05aada5223c741e14bda28
1 parent 4aca4fb commit ded2bca

File tree

7 files changed

+7
-9
lines changed

7 files changed

+7
-9
lines changed

.circleci/Dockerfiles/Dockerfile.android

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
# and build a Android application that can be used to run the
1515
# tests specified in the scripts/ directory.
1616
#
17-
FROM reactnativecommunity/react-native-android:9.0
17+
FROM reactnativecommunity/react-native-android:v10.0
1818

1919
LABEL Description="React Native Android Test Image"
2020
LABEL maintainer="Meta Open Source <[email protected]>"

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ executors:
113113
reactnativeandroid:
114114
<<: *defaults
115115
docker:
116-
- image: reactnativecommunity/react-native-android:9.0
116+
- image: reactnativecommunity/react-native-android:v10.0
117117
resource_class: "xlarge"
118118
environment:
119119
- TERM: "dumb"

build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ version =
3030
group = "com.facebook.react"
3131

3232
val ndkPath by extra(System.getenv("ANDROID_NDK"))
33-
val ndkVersion by extra(System.getenv("ANDROID_NDK_VERSION") ?: "23.1.7779620")
33+
val ndkVersion by extra(System.getenv("ANDROID_NDK_VERSION") ?: "25.1.8937393")
3434
val sonatypeUsername = findProperty("SONATYPE_USERNAME")?.toString()
3535
val sonatypePassword = findProperty("SONATYPE_PASSWORD")?.toString()
3636

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
"prettier": "prettier --write \"./**/*.{js,md,yml,ts,tsx}\"",
2828
"format-check": "prettier --list-different \"./**/*.{js,md,yml,ts,tsx}\"",
2929
"update-lock": "npx yarn-deduplicate",
30-
"docker-setup-android": "docker pull reactnativecommunity/react-native-android:9.0",
30+
"docker-setup-android": "docker pull reactnativecommunity/react-native-android:v10.0",
3131
"docker-build-android": "docker build -t reactnativeci/android -f .circleci/Dockerfiles/Dockerfile.android .",
3232
"test-android-run-instrumentation": "docker run --cap-add=SYS_ADMIN -it reactnativeci/android bash .circleci/Dockerfiles/scripts/run-android-docker-instrumentation-tests.sh",
3333
"test-android-run-unit": "docker run --cap-add=SYS_ADMIN -it reactnativeci/android bash .circleci/Dockerfiles/scripts/run-android-docker-unit-tests.sh",

packages/react-native/ReactAndroid/gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ ANDROIDX_AUTOFILL_VERSION=1.1.0
77
ANDROIDX_TEST_VERSION=1.1.0
88
ANDROIDX_TRACING_VERSION=1.1.0
99
ASSERTJ_VERSION=3.21.0
10-
FBJNI_VERSION=0.4.0
10+
FBJNI_VERSION=0.5.1
1111
FRESCO_VERSION=3.0.0
1212
INFER_ANNOTATIONS_VERSION=0.18.0
1313
JAVAX_INJECT_VERSION=1

packages/react-native/ReactAndroid/hermes-engine/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ android {
258258
}
259259

260260
dependencies {
261-
implementation("com.facebook.fbjni:fbjni:0.4.0")
261+
implementation("com.facebook.fbjni:fbjni:0.5.1")
262262
implementation("com.facebook.soloader:soloader:0.10.5")
263263
implementation("com.facebook.yoga:proguard-annotations:1.19.0")
264264
implementation("androidx.annotation:annotation:1.3.0")

packages/react-native/template/android/build.gradle

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@ buildscript {
66
minSdkVersion = 21
77
compileSdkVersion = 33
88
targetSdkVersion = 33
9-
10-
// We use NDK 23 which has both M1 support and is the side-by-side NDK version from AGP.
11-
ndkVersion = "23.1.7779620"
9+
ndkVersion = "25.1.8937393"
1210
kotlinVersion = "1.8.0"
1311
}
1412
repositories {

0 commit comments

Comments
 (0)