Skip to content

Update: SigProfilerAssignment to v0.2.1 with updated requirements and… #55782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mdbarnesUCSD
Copy link
Contributor

@mdbarnesUCSD mdbarnesUCSD commented Apr 30, 2025

… strict CLI test

  • Updated Python requirement to >=3.9
  • Updated pandas and numpy requirements to >=2.0.0 to match upstream setup.py
  • Added run_test.sh to validate CLI entry point via 'SigProfilerAssignment --help'

Note: This recipe depends on SigProfilerMatrixGenerator >=1.3.0, which is currently under review in bioconda/bioconda-recipes#55778. Until that PR is merged and available on Bioconda’s master, this build may fail due to unresolved dependencies.

Once #55778 is merged, this recipe will resolve when this branch is updated with master.


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@mdbarnesUCSD
Copy link
Contributor Author

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Apr 30, 2025
Comment on lines +38 to +40
commands:
- cp ${RECIPE_DIR}/run_test.sh .
- bash run_test.sh
Copy link
Member

@nh13 nh13 May 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like RECIPE_DIR is empty (cp: can't stat '/run_test.sh': No such file or directory). I don't see RECIPE_DIR used in this section in other recipes. Could you just inline the two test commands?

I am curious why the test requires these packages but not the install?

Suggested change
commands:
- cp ${RECIPE_DIR}/run_test.sh .
- bash run_test.sh
commands:
- SigProfilerAssignment --help
requires:
- pypdf
- pymupdf
- alive-progress

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we need osx support: conda-forge/pymupdf-feedstock#34

@mdbarnesUCSD
Copy link
Contributor Author

Thanks for the feedback on this PR. I’ve released an updated version of SigProfilerAssignment (v0.2.2), which simplifies the recipe and aligns it more closely with the package’s setup.py.

Rather than continue revising this PR, I’ve opened a new one for v0.2.2.

Appreciate the time and guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants