Skip to content

Commit 9336773

Browse files
authored
Merge pull request #323 from JakaKokosar/owgenialisexpressions
[FIX] Owgenialisexpressions: fix sign in dialog, remove info box
2 parents 05a7b1b + 20b6ff8 commit 9336773

File tree

1 file changed

+6
-39
lines changed

1 file changed

+6
-39
lines changed

orangecontrib/bioinformatics/widgets/OWGenialisExpressions.py

+6-39
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
from Orange.data import Table, Domain, ContinuousVariable
1717
from Orange.util import wrap_callback
1818
from Orange.widgets import gui, widget, settings
19-
from Orange.widgets.widget import Msg, Output, StateInfo
19+
from Orange.widgets.widget import Msg, Output
2020
from Orange.data.pandas_compat import vars_from_df
2121
from Orange.widgets.utils.concurrent import TaskState, ConcurrentWidgetMixin
2222
from Orange.widgets.utils.itemmodels import PyTableModel
@@ -264,11 +264,6 @@ def __init__(self):
264264
# Cache clinical metadata
265265
self.clinical_metadata: Optional[Table] = None
266266

267-
# Control area
268-
self.info_box = gui.widgetLabel(
269-
gui.widgetBox(self.controlArea, "Info", margin=3), 'No data on output.'
270-
)
271-
272267
self.exp_type_combo = gui.comboBox(
273268
self.controlArea,
274269
self,
@@ -377,8 +372,6 @@ def __invalidate(self):
377372
self.Warning.multiple_feature_type.clear()
378373
self.Warning.unexpected_feature_type.clear()
379374
self.Warning.no_data_objects.clear()
380-
self.info.set_output_summary(StateInfo.NoOutput)
381-
self.update_info_box()
382375

383376
def update_user_status(self):
384377
user = self.res.get_currently_logged_user()
@@ -401,30 +394,6 @@ def update_user_status(self):
401394
self.user_info.setText(user_info)
402395
self.server_info.setText(f'Server: {self.res.url[8:]}')
403396

404-
def update_info_box(self):
405-
if self.data_table:
406-
total_genes = len(self.data_table.domain.attributes)
407-
known_genes = len(
408-
[
409-
col
410-
for col in self.data_table.domain.attributes
411-
if len(col.attributes)
412-
]
413-
)
414-
415-
info_text = (
416-
'{} genes on output\n'
417-
'{} genes match Entrez database\n'
418-
'{} genes with match conflicts\n'.format(
419-
total_genes, known_genes, total_genes - known_genes
420-
)
421-
)
422-
423-
else:
424-
info_text = 'No data on output.'
425-
426-
self.info_box.setText(info_text)
427-
428397
def sign_in(self, silent=False):
429398
dialog = SignIn(self, server_type=resolwe.RESOLWE_PLATFORM)
430399

@@ -437,7 +406,7 @@ def sign_in(self, silent=False):
437406
url=resolwe.resapi.DEFAULT_URL, server_type=resolwe.RESOLWE_PLATFORM
438407
)
439408

440-
if not silent and dialog.exec_():
409+
if not silent and dialog.exec():
441410
self.res = dialog.resolwe_instance
442411

443412
def sign_out(self):
@@ -536,21 +505,22 @@ def normalize(self, table: Table) -> Optional[Table]:
536505

537506
return table
538507

508+
@gui.deferred
539509
def commit(self):
540510
self.Warning.no_data_objects.clear()
541511
self.cancel()
542512
self.start(self.runner)
543513

544514
def on_output_option_changed(self):
545515
self.data_table = None
546-
self.commit()
516+
self.commit.deferred()
547517

548518
def on_clinical_data_changed(self):
549519
self.clinical_metadata = self.fetch_clinical_metadata()
550-
self.commit()
520+
self.commit.deferred()
551521

552522
def on_normalization_changed(self):
553-
self.commit()
523+
self.commit.deferred()
554524

555525
def on_selection_changed(self):
556526
self.__invalidate()
@@ -614,9 +584,6 @@ def get_selected_row_data(self, column: int) -> Optional[str]:
614584

615585
def on_done(self, table: Table):
616586
if table:
617-
samples, genes = table.X.shape
618-
self.info.set_output_summary(f'Samples: {samples} Genes: {genes}')
619-
self.update_info_box()
620587
self.Outputs.table.send(table)
621588

622589
def on_exception(self, ex):

0 commit comments

Comments
 (0)