Skip to content

Genialis Expressions widget should be updated to account for the breaking changes in ReSDK #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mstajdohar opened this issue Apr 5, 2022 · 5 comments · Fixed by #311
Closed

Genialis Expressions widget should be updated to account for the breaking changes in ReSDK #310

mstajdohar opened this issue Apr 5, 2022 · 5 comments · Fixed by #311
Assignees
@JakaKokosar
Labels
bug

Comments

@mstajdohar
Copy link

Change import resdk to import resdk.tables
Change coll_table = resdk.tables.CollectionTables to coll_table = resdk.tables.RNATables

Discuss with @robertcv and @JureZmrzlikar if there are more edge cases.
@mstajdohar mstajdohar added the bug label Apr 5, 2022
@mstajdohar
Copy link
Author

cc @JakaKokosar

@JureZmrzlikar
Copy link
Contributor

I think the breaking changes are (already) well descried in #304

@JakaKokosar
Copy link
Member

I have this on my mind. I didn't find time to work on this, but I will look into it soon, hopefully as soon as next week.

@JakaKokosar JakaKokosar self-assigned this Apr 14, 2022
@uksurd88
Copy link

Any update on this? Expressions plugin can't load a collection because of the abovementioned change. Workaround is to install the bioinformatics add-on from source but the .dmg file is not updated.

@JakaKokosar JakaKokosar mentioned this issue Nov 23, 2022
Merged
3 tasks
@JakaKokosar
Copy link
Member

JakaKokosar commented Nov 23, 2022 •
edited
Loading

Fixed in #311 and will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JakaKokosar JakaKokosar

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ENH] Add QC data to Genialis Expression widget JakaKokosar/orange3-bioinformatics
4 participants
@uksurd88 @mstajdohar @JureZmrzlikar @JakaKokosar