Skip to content

Commit d2fecc9

Browse files
committed
ci: Switch from "RelWithDebInfo" to "Release" config for MSVC jobs
It is reasonable to test a configuration that is used in the Bitcoin Core build. For MSVC, the "Release" config (/O2 /Ob2) is preferable over "RelWithDebInfo" (/Zi /O2 /Ob1) for the following reasons: 1. /Ob2 can be slightly better than /Ob1 for performance; see: https://learn.microsoft.com/en-us/cpp/build/reference/ob-inline-function-expansion 2. /Zi, which produces a separate PDB file that contains all the symbolic debugging information, is incompatible with ccache; see: https://learn.microsoft.com/en-us/cpp/build/reference/z7-zi-zi-debug-information-format https://github.com/ccache/ccache/wiki/MS-Visual-Studio
1 parent 35c0fdc commit d2fecc9

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -735,20 +735,20 @@ jobs:
735735
run: cmake -E env CFLAGS="/WX ${{ matrix.configuration.cpp_flags }}" cmake -B build -DSECP256K1_ENABLE_MODULE_RECOVERY=ON -DSECP256K1_BUILD_EXAMPLES=ON ${{ matrix.configuration.cmake_options }}
736736

737737
- name: Build
738-
run: cmake --build build --config RelWithDebInfo -- /p:UseMultiToolTask=true /maxCpuCount
738+
run: cmake --build build --config Release -- /p:UseMultiToolTask=true /maxCpuCount
739739

740740
- name: Binaries info
741741
# Use the bash shell included with Git for Windows.
742742
shell: bash
743743
run: |
744-
cd build/src/RelWithDebInfo && file *tests.exe bench*.exe libsecp256k1-*.dll || true
744+
cd build/src/Release && file *tests.exe bench*.exe libsecp256k1-*.dll || true
745745
746746
- name: Check
747747
run: |
748-
ctest -C RelWithDebInfo --test-dir build -j ([int]$env:NUMBER_OF_PROCESSORS + 1)
749-
build\src\RelWithDebInfo\bench_ecmult.exe
750-
build\src\RelWithDebInfo\bench_internal.exe
751-
build\src\RelWithDebInfo\bench.exe
748+
ctest -C Release --test-dir build -j ([int]$env:NUMBER_OF_PROCESSORS + 1)
749+
build\src\Release\bench_ecmult.exe
750+
build\src\Release\bench_internal.exe
751+
build\src\Release\bench.exe
752752
753753
win64-native-headers:
754754
name: "x64 (MSVC): C++ (public headers)"

0 commit comments

Comments
 (0)