fix: change buildpack, builder and stack ids #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance
added
artifacts/stacks
Instead of using `com.redhat.faas`, these ids should be prefixed `dev.boson`. Fixes: #42 Signed-off-by: Lance Ball <[email protected]>
lance
force-pushed
the
lance/42-change-stack-builder-buildpack-ids
branch
from
ef1478c to
dcfcd61
Compare
|
@zroubalik thanks for the review. I've addressed your points. |
Signed-off-by: Lance Ball <[email protected]>
zroubalik
approved these changes
Nov 26, 2020
| $(PACK_CMD) create-builder $(QUARKUS_JVM_BUILDER_REPO):$(VERSION_TAG) --config $$TMP_BLDRS/quarkus-jvm.toml && \ | ||
| $(PACK_CMD) create-builder $(QUARKUS_NATIVE_BUILDER_REPO):$(VERSION_TAG) --config $$TMP_BLDRS/quarkus-native.toml && \ | ||
| $(PACK_CMD) create-builder $(SPRINGBOOT_BUILDER_REPO):$(VERSION_TAG) --config $$TMP_BLDRS/springboot.toml -v && \ | ||
| $(PACK_CMD) create-builder --pull-policy=never $(NODEJS_BUILDER_REPO):$(VERSION_TAG) --config $$TMP_BLDRS/node.toml && \ |
There was a problem hiding this comment.
I am curious why--pull-policy=never is being added?
There was a problem hiding this comment.
I did this originally because, when building with new stack IDs, pack was pulling the images from quay.io that had the old IDs. I think, in general, since all of the images are being versioned published together, it's probably best to never pull images during a build, but only use the images that have just been built.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using
com.redhat.faas, these ids should be prefixeddev.boson.Fixes: #42
Signed-off-by: Lance Ball [email protected]