Skip to content

[iOS] UK/JP Onboarding: Show PIP animation #44182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
timchilds opened this issue Feb 24, 2025 · 2 comments · Fixed by brave/brave-core#28496
Closed

[iOS] UK/JP Onboarding: Show PIP animation #44182

timchilds opened this issue Feb 24, 2025 · 2 comments · Fixed by brave/brave-core#28496
Assignees
@kylehickinson
Labels
enhancement onboarding Front-end related to helping a new user learn about features within the browser. OS/iOS Fixes related to iOS browser functionality QA/In-Progress Indicates that QA is currently in progress for that particular issue QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.78.x - Beta

Comments

@timchilds
Copy link

timchilds commented Feb 24, 2025 •
edited
Loading

Description

Display a PIP video containing the set default animation after the user taps the set default button on the UK/JP onboarding set default screen.

Slack thread: https://bravesoftware.slack.com/archives/C07LWRLAYH5/p1740363865116839
@timchilds timchilds added OS/iOS Fixes related to iOS browser functionality onboarding Front-end related to helping a new user learn about features within the browser. enhancement QA/Yes labels Feb 24, 2025
@aguscruiz
Copy link

Small preview on how it'd look here
https://www.figma.com/design/FiluJhwOjucQL4iGLmVZLW/iOS-Onboarding?node-id=5160-14577&t=4qvSJfS07oM0P8BF-1

Image

@kylehickinson kylehickinson mentioned this issue Apr 3, 2025
Merged
@brave-builds brave-builds added this to the 1.79.x - Nightly milestone Apr 7, 2025
@brave-builds brave-builds mentioned this issue Apr 7, 2025
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.78.83 or higher for 1.78.x verification 👍

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylehickinson kylehickinson

Labels
enhancement onboarding Front-end related to helping a new user learn about features within the browser. OS/iOS Fixes related to iOS browser functionality QA/In-Progress Indicates that QA is currently in progress for that particular issue QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.78.x - Beta
Development

Successfully merging a pull request may close this issue.

[iOS] Show PiP video in new onboarding default browser step brave/brave-core
6 participants
@kylehickinson @kjozwiak @aguscruiz @timchilds @brave-builds @hffvld