Skip to content

[ads] Fetch new tab takeover CRX component based on GeoIP location #45531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tmancey opened this issue Apr 17, 2025 · 0 comments · May be fixed by brave/brave-core#28769
Open

[ads] Fetch new tab takeover CRX component based on GeoIP location #45531

tmancey opened this issue Apr 17, 2025 · 0 comments · May be fixed by brave/brave-core#28769
Assignees
@tmancey @aseren
Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude

Comments

@tmancey
Copy link
Contributor

tmancey commented Apr 17, 2025 •
edited
Loading

Description

I initially considered using RegionalCapabilitiesService, but Chromium states that it’s intended for Google-only use. Introducing it now could be a risky change for ads. However, as Chromium evolves its approach to regional capabilities, we can reassess and decide whether that would make sense in the future.
@tmancey tmancey added this to Ads Apr 17, 2025
@github-project-automation github-project-automation bot moved this to New issues in Ads Apr 17, 2025
@tmancey tmancey moved this from New issues to In progress in Ads Apr 17, 2025
@tmancey tmancey self-assigned this Apr 17, 2025
@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude labels Apr 17, 2025
@tmancey tmancey moved this from In progress to Review in Ads Apr 22, 2025
@tmancey tmancey linked a pull request Apr 22, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

@aseren aseren

Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude
Projects
Ads
Status: Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ads] Fetch new tab takeover CRX component based on GeoIP location brave/brave-core
2 participants
@tmancey @aseren