Skip to content

[ads] Ads Settings can't be opened after disabling all ads options #45568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 of 6 tasks
hffvld opened this issue Apr 18, 2025 · 0 comments · Fixed by brave/brave-core#28765
Closed
2 of 6 tasks

[ads] Ads Settings can't be opened after disabling all ads options #45568

hffvld opened this issue Apr 18, 2025 · 0 comments · Fixed by brave/brave-core#28765
Assignees
@tmancey @deeppandya @zenparsing
Labels
bug feature/ads feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/Yes regression rewards-3.0
Milestone
1.79.x - Nightly

Comments

@hffvld
Copy link
Contributor

hffvld commented Apr 18, 2025 •
edited
Loading

Description

Ads Settings can't be opened after disabling all ads options.

NOTE: This is a Regression that started with 1.78.x build.

Steps to reproduce

  1. Launch Brave
  2. Enable Brave Rewards
  3. Tap Ads Settings
  4. Disable all toggle switches
  5. Try to tap Ads Settings again > Observe

Actual result

Ads Settings can't be opened after disabling all ads options.

1
Screencast
1

Expected result

The Ads Settings must be accessible even after disabling all ads options.

Reproduces how often

Easily reproduced

Brave version

Brave build: 1.78.84
Chromium: 135.0.7049.100 (Official Build) beta (64-bit)

Device

  • Brand/model: Pixel 6, Pixel 7
  • Android version: 15, 16

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@hffvld hffvld added bug feature/rewards OS/Android Fixes related to Android browser functionality QA/Yes rewards-3.0 labels Apr 18, 2025
@Miyayes Miyayes added priority/P1 A very extremely bad problem. We might push a hotfix for it. OS/Desktop labels Apr 22, 2025
@github-project-automation github-project-automation bot moved this to New Issues in Brave Rewards Apr 22, 2025
@tmancey tmancey changed the title Ads Settings can't be opened after disabling all ads options [ads] Ads Settings can't be opened after disabling all ads options Apr 22, 2025
@tmancey tmancey added this to Ads Apr 22, 2025
@github-project-automation github-project-automation bot moved this to New issues in Ads Apr 22, 2025
@tmancey tmancey self-assigned this Apr 22, 2025
@tmancey tmancey mentioned this issue Apr 22, 2025
Merged
@brave-builds brave-builds mentioned this issue Apr 22, 2025
Open
7 tasks
@github-project-automation github-project-automation bot moved this from New Issues to Done in Brave Rewards Apr 22, 2025
@github-project-automation github-project-automation bot moved this from New issues to Done in Ads Apr 22, 2025
@brave-builds brave-builds added this to the 1.79.x - Nightly milestone Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

@deeppandya deeppandya

@zenparsing zenparsing

Labels
bug feature/ads feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/Yes regression rewards-3.0
Projects
Ads
Status: Done
Brave Rewards
Status: Done
Milestone
1.79.x - Nightly
Development

Successfully merging a pull request may close this issue.

[ads] Ads Settings can't be opened after disabling all ads options brave/brave-core
7 participants
@tmancey @deeppandya @zenparsing @Miyayes @btlechowski @brave-builds @hffvld