Skip to content

Use SimpleHash CDN proxy only if NFT image belongs to SimpleHash host #45613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
6 tasks done
onyb opened this issue Apr 22, 2025 · 0 comments · May be fixed by brave/brave-core#28768
Open
6 tasks done

Use SimpleHash CDN proxy only if NFT image belongs to SimpleHash host #45613

onyb opened this issue Apr 22, 2025 · 0 comments · May be fixed by brave/brave-core#28768
Assignees
@onyb
Labels
feature/web3/wallet/core feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude

Comments

@onyb
Copy link
Member

onyb commented Apr 22, 2025

Description

Currently all NFT image URLs are served through the SimpleHash CDN, via a Brave proxy. Essentially, we modify the host of all NFT images from https://cdn.simplehash.com/assets/img.png to https://simplehash.wallet-cdn.brave.com/assets/img.png.

The above will result in broken images if the host is not cdn.simplehash.com to begin with. Apply this conditional while using the Brave proxy.

Steps to reproduce

N/A

Actual result

N/A

Expected result

NFT images continue to be visible in the portfolio view.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.77.100 Chromium: 135.0.7049.100 (Official Build) (arm64)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

Needs to be uplifted to release
@onyb onyb added feature/web3/wallet Integrating Ethereum+ wallet support feature/web3/wallet/core feature/web3/wallet/nft OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude labels Apr 22, 2025
@onyb onyb self-assigned this Apr 22, 2025
@onyb onyb added this to Web3 Apr 22, 2025
@onyb onyb linked a pull request Apr 22, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
feature/web3/wallet/core feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude
Projects
Web3
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(wallet): use simplehash cdn proxy only for simplehash host brave/brave-core
1 participant
@onyb