Skip to content

Commit 4d1ca0b

Browse files
authored
Merge pull request #166 from rolfsimoes/dev
Fix #160
2 parents 2f6452f + e5e0cbe commit 4d1ca0b

File tree

3 files changed

+10
-16
lines changed

3 files changed

+10
-16
lines changed

R/assets-funs.R

+4-6
Original file line numberDiff line numberDiff line change
@@ -342,10 +342,7 @@ assets_select <- function(items, ..., asset_names = NULL, select_fn = NULL) {
342342
assets_select.doc_item <- function(items, ...,
343343
asset_names = NULL,
344344
select_fn = NULL) {
345-
exprs <- unquote(
346-
expr = as.list(substitute(list(...), env = environment())[-1]),
347-
env = parent.frame()
348-
)
345+
exprs <- as.list(substitute(list(...), env = environment()))[-1]
349346
init_length <- length(items$assets)
350347
if (!is.null(asset_names)) {
351348
asset_names <- intersect(names(items$assets), asset_names)
@@ -354,9 +351,10 @@ assets_select.doc_item <- function(items, ...,
354351
if (length(exprs) > 0) {
355352
if (!is.null(names(exprs)))
356353
.error("Select expressions cannot be named.")
357-
for (i in seq_along(exprs)) {
354+
for (expr in exprs) {
355+
expr <- unquote(expr = expr, env = parent.frame())
358356
sel <- map_lgl(names(items$assets), function(key) {
359-
select_eval(key = key, asset = items$assets[[key]], expr = exprs[[i]])
357+
select_eval(key = key, asset = items$assets[[key]], expr = expr)
360358
})
361359
items$assets <- items$assets[sel]
362360
}

R/items-funs.R

+4-6
Original file line numberDiff line numberDiff line change
@@ -477,15 +477,13 @@ items_filter <- function(items, ..., filter_fn = NULL) {
477477
#' @export
478478
items_filter.doc_items <- function(items, ..., filter_fn = NULL) {
479479
init_length <- items_length(items)
480-
exprs <- unquote(
481-
expr = as.list(substitute(list(...), env = environment())[-1]),
482-
env = parent.frame()
483-
)
480+
exprs <- as.list(substitute(list(...), env = environment()))[-1]
484481
if (length(exprs) > 0) {
485482
if (!is.null(names(exprs)))
486483
.error("Filter expressions cannot be named.")
487-
for (i in seq_along(exprs)) {
488-
sel <- map_lgl(items$features, eval_filter_expr, expr = exprs[[i]])
484+
for (expr in exprs) {
485+
expr <- unquote(expr = expr, env = parent.frame())
486+
sel <- map_lgl(items$features, eval_filter_expr, expr = expr)
489487
items$features <- items$features[sel]
490488
}
491489
}

R/static-funs.R

+2-4
Original file line numberDiff line numberDiff line change
@@ -227,12 +227,10 @@ links <- function(x, ...) {
227227

228228
#' @export
229229
links.rstac_doc <- function(x, ...) {
230-
exprs <- unquote(
231-
expr = as.list(substitute(list(...), env = environment())[-1]),
232-
env = parent.frame()
233-
)
230+
exprs <- as.list(substitute(list(...), env = environment()))[-1]
234231
sel <- !logical(length(x$links))
235232
for (expr in exprs) {
233+
expr <- unquote(expr = expr, env = parent.frame())
236234
sel <- sel & map_lgl(x$links, function(x) {
237235
tryCatch(
238236
eval(expr, envir = x),

0 commit comments

Comments
 (0)