Skip to content

Commit e51318e

Browse files
committed
fixup
1 parent 8fd8e7f commit e51318e

File tree

3 files changed

+15
-6
lines changed

3 files changed

+15
-6
lines changed

src/main/java/org/broadinstitute/hellbender/tools/genomicsdb/GenomicsDBImport.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,7 @@ public final class GenomicsDBImport extends GATKTool {
394394

395395
//executor service used when vcfInitializerThreads > 1
396396
private ExecutorService inputPreloadExecutorService;
397-
397+
398398
/**
399399
* Get the largest interval per contig that contains the intervals specified on the command line.
400400
* @param getIntervals intervals to be transformed

src/test/java/org/broadinstitute/hellbender/tools/spark/PileupSparkIntegrationTest.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public Object[][] shuffleParameters() {
2727

2828
@Test(dataProvider = "shuffle")
2929
public void testSimplePileup(boolean useShuffle) throws Exception {
30-
final File out = createTempFile();
30+
final File out = createTempDir();
3131
final ArgumentsBuilder args = new ArgumentsBuilder();
3232
args.addRaw("--input");
3333
args.addRaw(NA12878_20_21_WGS_bam);
@@ -47,7 +47,7 @@ public void testSimplePileup(boolean useShuffle) throws Exception {
4747

4848
@Test(dataProvider = "shuffle")
4949
public void testVerbosePileup(boolean useShuffle) throws Exception {
50-
final File out = createTempFile();
50+
final File out = createTempDir();
5151
final ArgumentsBuilder args = new ArgumentsBuilder();
5252
args.addRaw("--input");
5353
args.addRaw(NA12878_20_21_WGS_bam);
@@ -68,7 +68,7 @@ public void testVerbosePileup(boolean useShuffle) throws Exception {
6868

6969
@Test(dataProvider = "shuffle")
7070
public void testFeaturesPileup(boolean useShuffle) throws Exception {
71-
final File out = createTempFile();
71+
final File out = createTempDir();
7272
final ArgumentsBuilder args = new ArgumentsBuilder();
7373
args.addRaw("--input");
7474
args.addRaw(NA12878_20_21_WGS_bam);
@@ -89,7 +89,7 @@ public void testFeaturesPileup(boolean useShuffle) throws Exception {
8989

9090
@Test(dataProvider = "shuffle")
9191
public void testInsertLengthPileup(boolean useShuffle) throws Exception {
92-
final File out = createTempFile();
92+
final File out = createTempDir();
9393
final ArgumentsBuilder args = new ArgumentsBuilder();
9494
args.addRaw("--input");
9595
args.addRaw(NA12878_20_21_WGS_bam);
@@ -122,7 +122,7 @@ public void testFeaturesPileupHdfs(boolean useShuffle) throws Exception {
122122
cluster.getFileSystem().copyFromLocalFile(new Path(dbsnp_138_b37_20_21_vcf), vcfPath);
123123
cluster.getFileSystem().copyFromLocalFile(new Path(dbsnp_138_b37_20_21_vcf + ".idx"), idxPath);
124124

125-
final File out = createTempFile();
125+
final File out = createTempDir();
126126
final ArgumentsBuilder args = new ArgumentsBuilder();
127127
args.addRaw("--input");
128128
args.addRaw(NA12878_20_21_WGS_bam);

src/testUtils/java/org/broadinstitute/hellbender/testutils/BaseTest.java

+9
Original file line numberDiff line numberDiff line change
@@ -353,6 +353,15 @@ public static File createTempDir(final String prefix){
353353
return IOUtils.createTempDir(prefix);
354354
}
355355

356+
/**
357+
* Creates an empty temp directory which will be deleted on exit after tests are complete
358+
*
359+
* @return an empty directory will be deleted after the program exits
360+
*/
361+
public static File createTempDir(){
362+
return createTempDir("tmp");
363+
}
364+
356365
/**
357366
* Log this message so that it shows up inline during output as well as in html reports
358367
*/

0 commit comments

Comments
 (0)