Added a null check to BugsnagErrorHandler (#2295)

* fix: 🐛 fail quietly when client is null

* docs: 📝 update CHANGELOG.md

Author: gingerbenw

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## [Unreleased]
+
+### Fixed
+
+- (plugin-angular) Added a null check so BugsnagErrorHandler fails silently when misconfigured [#2295](https://github.com/bugsnag/bugsnag-js/pull/2295)
+
 ## [8.2.0] - 2025-01-27
 
 ### Added

packages/plugin-angular/src/lib/bugsnag-error-handler.ts

@@ -2,11 +2,11 @@ import { ErrorHandler, VERSION } from '@angular/core'
 import Bugsnag, { Client } from '@bugsnag/js'
 
 type BugsnagWithInternals = typeof Bugsnag & {
-  _client: Client
+  _client: Client | null
 }
 
 class BugsnagErrorHandler implements ErrorHandler {
-  public bugsnagClient: Client;
+  public bugsnagClient: Client | null;
 
   constructor (client?: Client) {
     if (client) {
@@ -17,31 +17,35 @@ class BugsnagErrorHandler implements ErrorHandler {
 
     // Add angular runtime to device metadata
     const device = { runtimeVersions: { angular: VERSION.full } }
-    this.bugsnagClient.addOnSession(session => {
-      session.device = { ...session.device, ...device }
-    })
-    this.bugsnagClient.addOnError((event) => {
-      event.device = { ...event.device, ...device }
-    })
+    if (this.bugsnagClient) {
+      this.bugsnagClient.addOnSession(session => {
+        session.device = { ...session.device, ...device }
+      })
+      this.bugsnagClient.addOnError((event) => {
+        event.device = { ...event.device, ...device }
+      })
+    }
   }
 
   handleError (error: any): void {
-    const handledState = {
-      severity: 'error',
-      severityReason: { type: 'unhandledException' },
-      unhandled: true
+    if (this.bugsnagClient) {
+      const handledState = {
+        severity: 'error',
+        severityReason: { type: 'unhandledException' },
+        unhandled: true
+      }
+
+      const event = this.bugsnagClient.Event.create(
+        error,
+        true,
+        handledState,
+        'angular error handler',
+        1
+      )
+
+      this.bugsnagClient._notify(event)
     }
 
-    const event = this.bugsnagClient.Event.create(
-      error,
-      true,
-      handledState,
-      'angular error handler',
-      1
-    )
-
-    this.bugsnagClient._notify(event)
-
     // Replicate the default behaviour of the angular error handler by calling console.error
     // previously this called ErrorHandler.prototype.handleError but this caused a mismatch between
     // the compiled code and the angular version used in the application.