decomposedfs: do not swallow errors when creating nodes (cs3org#2457)

butonic · butonic · commit a955d6269826 · 2022-02-14T09:23:03.000Z
Signed-off-by: Jörn Friedrich Dreyer &lt;jfd@butonic.de&gt;
diff --git a/changelog/unreleased/do-not-swallow-error.md b/changelog/unreleased/do-not-swallow-error.md
@@ -0,0 +1,5 @@
+Bugfix: do not swallow error
+
+decomposedfs not longer swallows errors when creating a node fails.
+
+https://github.com/cs3org/reva/pull/2457
diff --git a/pkg/storage/utils/decomposedfs/tree/tree.go b/pkg/storage/utils/decomposedfs/tree/tree.go
@@ -259,7 +259,7 @@ func (t *Tree) CreateDir(ctx context.Context, n *node.Node) (err error) {
 
 	err = t.createNode(n, owner)
 	if err != nil {
-		return nil
+		return
 	}
 
 	// make child appear in listings

Original file line number	Diff line number	Diff line change
`@@ -259,7 +259,7 @@ func (t Tree) CreateDir(ctx context.Context, n node.Node) (err error) {`
`259`	`259`
`260`	`260`	`err = t.createNode(n, owner)`
`261`	`261`	`if err != nil {`
`262`		`- return nil`
	`262`	`+ return`
`263`	`263`	`}`
`264`	`264`
`265`	`265`	`// make child appear in listings`