Fix logging bug on task completer by adding nil check to error (#6603)

fimanishi · web-flow · commit 2e2c20a942c4 · 2025-01-08T13:23:04.000-08:00
diff --git a/service/matching/tasklist/task_completer.go b/service/matching/tasklist/task_completer.go
@@ -154,7 +154,7 @@ func (tc *taskCompleterImpl) CompleteTaskIfStarted(ctx context.Context, task *In
 
 	err := tc.throttleRetry.Do(ctx, op)
 
-	if !errors.Is(err, errDomainIsActive) && !errors.Is(err, errTaskNotStarted) {
+	if err != nil && !errors.Is(err, errDomainIsActive) && !errors.Is(err, errTaskNotStarted) {
 		tc.scope.IncCounter(metrics.StandbyClusterTasksCompletionFailurePerTaskList)
 		tc.logger.Error("Error completing task on domain's standby cluster", tag.Error(err))
 	}

Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,7 @@ func (tc taskCompleterImpl) CompleteTaskIfStarted(ctx context.Context, task In`
`154`	`154`
`155`	`155`	`err := tc.throttleRetry.Do(ctx, op)`
`156`	`156`
`157`		`- if !errors.Is(err, errDomainIsActive) && !errors.Is(err, errTaskNotStarted) {`
	`157`	`+ if err != nil && !errors.Is(err, errDomainIsActive) && !errors.Is(err, errTaskNotStarted) {`
`158`	`158`	`tc.scope.IncCounter(metrics.StandbyClusterTasksCompletionFailurePerTaskList)`
`159`	`159`	`tc.logger.Error("Error completing task on domain's standby cluster", tag.Error(err))`
`160`	`160`	`}`