Error on using reserved keyword for migration name (#2328)

Co-authored-by: Mark Scherer <[email protected]>

Author: MasterOdin

src/Phinx/Console/Command/Create.php

@@ -36,6 +36,15 @@ class Create extends AbstractCommand
      */
     public const CREATION_INTERFACE = 'Phinx\Migration\CreationInterface';
 
+    // PHP keywords from https://www.php.net/manual/en/reserved.keywords.php
+    private array $keywords = [
+        'abstract', 'and', 'array', 'as', 'break', 'callable', 'case', 'catch', 'class', 'clone', 'const',
+        'continue', 'declare', 'default', 'die', 'do', 'echo', 'else', 'elseif', 'empty', 'enddeclare', 'endfor',
+        'endforeach', 'endif', 'endswitch', 'endwhile', 'eval', 'exit', 'extends', 'final', 'finally', 'for', 'foreach',
+        'function', 'global', 'goto', 'if', 'implements', 'include', 'include_once', 'instanceof', 'insteadof', 'interface',
+        'isset', 'list', 'namespace', 'new', 'or', 'parent', 'private', 'protected', 'public', 'return','static',
+    ];
+
     /**
      * {@inheritDoc}
      *
@@ -167,6 +176,13 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         $path = realpath($path);
         $className = $input->getArgument('name');
+        if ($className !== null && in_array(strtolower($className), $this->keywords)) {
+            throw new InvalidArgumentException(sprintf(
+                'The migration class name "%s" is a reserved PHP keyword. Please choose a different class name.',
+                $className
+            ));
+        }
+
         $offset = 0;
         do {
             $timestamp = Util::getCurrentTimestamp($offset++);

tests/Phinx/Console/Command/CreateTest.php

@@ -613,4 +613,20 @@ public function testCreateMigrationWithInvalidStyleFlagThrows(): void
         $exitCode = $commandTester->execute(['command' => $command->getName(), '--style' => 'foo']);
         $this->assertSame(AbstractCommand::CODE_ERROR, $exitCode);
     }
+
+    public function testCreateWithKeywordNameThrows(): void
+    {
+        $application = new PhinxApplication();
+        $application->add(new Create());
+
+        /** @var Create $command */
+        $command = $application->find('create');
+        $command->setConfig($this->config);
+
+        $commandTester = new CommandTester($command);
+
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('The migration class name "Class" is a reserved PHP keyword. Please choose a different class name.');
+        $commandTester->execute(['command' => $command->getName(), 'name' => 'Class']);
+    }
 }