Skip to content

Commit c35c26d

Browse files
tigrannajaryancarlosalberto
authored andcommitted
Fix missing apply_to_spans in OTEP 0152 (open-telemetry#180)
The OTEP text correctly says: >In addition it is also possible to optionally specify spans and events that the transformation should apply to. However, the block after that text is missing the apply_to_spans that the text alludes to. I wrote the text correctly but made a mistake when copy/pasting the yaml from my experimental codebase. I consider this to be a non-breaking change. It is a bug fix since the tag in yaml is supposed to be there according to the text.
1 parent a8dead6 commit c35c26d

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

text/0152-telemetry-schemas.md

+6-1
Original file line numberDiff line numberDiff line change
@@ -425,7 +425,9 @@ only to events of spans that have the specified name. Here is the structure:
425425

426426
This is similar to the "rename_attributes" transformation supported in "all" and
427427
"resource" sections. In addition it is also possible to optionally specify spans
428-
and events that the transformation should apply to. Here is the structure:
428+
and events that the transformation should apply to (both optional conditions
429+
must match, if specified, for transformation to be applicable). Here is the
430+
structure:
429431

430432
```yaml
431433
span_events:
@@ -436,6 +438,9 @@ and events that the transformation should apply to. Here is the structure:
436438
# in the previous version, the values are the new attribute name
437439
# starting from this version.
438440

441+
apply_to_spans:
442+
# Optional span names to apply to. If empty applies to all spans.
443+
439444
apply_to_events:
440445
# Optional event names to apply to. If empty applies to all events.
441446
```

0 commit comments

Comments
 (0)