Skip to content

IconData should derive common functionality #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lpotthast opened this issue Apr 29, 2023 · 2 comments
Closed

IconData should derive common functionality #2

lpotthast opened this issue Apr 29, 2023 · 2 comments

Comments

@lpotthast
Copy link
Contributor

IconData is a public item and does not derive anything. It should at least derive Debug.
It could probably safely

#[derive(Debug, PartialEq, Eq, Clone, Copy)]
@carloskiki
Copy link
Owner

can you take at my answer about this: carloskiki/leptos-icons#13.

I think you are right and we could derive these functionalities safely.

Do you think serde should be derived for individual icon enums, or only for IconData?

@carloskiki
Copy link
Owner

Big refactoring is in the way, I will make this change along with more stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lpotthast @carloskiki