Skip to content

1.9.3: File path completion in copy mode #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kcgthb opened this issue Feb 20, 2025 · 0 comments · May be fixed by #585
Open

1.9.3: File path completion in copy mode #584

kcgthb opened this issue Feb 20, 2025 · 0 comments · May be fixed by #585

Comments

@kcgthb
Copy link
Contributor

kcgthb commented Feb 20, 2025

It looks like file path completion doesn't work anymore in 1.9.3, when using copy mode:

$ clush -c /tmp/file[TAB][TAB]

doesn't complete /tmp/filename anymore.

Maybe a side effect of the new bash completions introduced in 1.9.3?
martinetd added a commit to martinetd/clustershell that referenced this issue Feb 20, 2025
@martinetd
completion: try to complete copy or command
fbb660e 
When using clush -c we should try to complete local files.

When not using -c, if a taget has already been set we can also try to
complete a command.
We could do like ssh and try to complete it on any node in the nodeset,
but a local completion is probably good enough.

And still complete possible options but only do so if a dash was
present, this is similar to what e.g. `ls` completion does

Fixes cea-hpc#584
@martinetd martinetd linked a pull request Feb 20, 2025 that will close this issue
Open
martinetd added a commit to martinetd/clustershell that referenced this issue Mar 1, 2025
@martinetd
completion: try to complete copy or command
915c1b7 
When using clush -c we should try to complete local files.

When not using -c, if a taget has already been set we can also try to
complete a command.
We could do like ssh and try to complete it on any node in the nodeset,
but a local completion is probably good enough.

And still complete possible options but only do so if a dash was
present, this is similar to what e.g. `ls` completion does

Fixes cea-hpc#584
martinetd added a commit to martinetd/clustershell that referenced this issue Mar 4, 2025
@martinetd
completion: try to complete copy or command
c05fdf4 
When using clush -c we should try to complete local files.

When not using -c, if a taget has already been set we can also try to
complete a command.
We could do like ssh and try to complete it on any node in the nodeset,
but a local completion is probably good enough.

And still complete possible options but only do so if a dash was
present, this is similar to what e.g. `ls` completion does

Fixes cea-hpc#584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

completion: try to complete copy or command martinetd/clustershell
1 participant
@kcgthb