Skip to content

refactor(all): use encoding.AppendBinary rather then custom things #4079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cristaloleg opened this issue Jan 30, 2025 · 1 comment
Closed

refactor(all): use encoding.AppendBinary rather then custom things #4079

cristaloleg opened this issue Jan 30, 2025 · 1 comment
Assignees
@cristaloleg
Labels
enhancement New feature or request kind:refactor Attached to refactoring PRs

Comments

@cristaloleg
Copy link
Contributor

Implementation ideas

Go 1.24 will give us a useful interface that will simplify work during serialization golang/go#62384

We have ~14 uses of appendTo methods which we can easily adapt to the new stdlib interface.

This issues should happen after #3773 merge
@cristaloleg cristaloleg added enhancement New feature or request kind:refactor Attached to refactoring PRs labels Jan 30, 2025
@cristaloleg cristaloleg self-assigned this Jan 30, 2025
@cristaloleg cristaloleg mentioned this issue Jan 30, 2025
Closed
@leopardracer leopardracer mentioned this issue Mar 10, 2025
Merged
@cristaloleg
Copy link
Contributor Author

Fixed in #4160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cristaloleg cristaloleg

Labels
enhancement New feature or request kind:refactor Attached to refactoring PRs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cristaloleg