Skip to content

Commit 503fe4e

Browse files
nityaravimelinath
authored andcommitted
Renamecontribute (GoogleCloudPlatform#12583)
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
1 parent c36036e commit 503fe4e

File tree

7 files changed

+15
-9
lines changed

7 files changed

+15
-9
lines changed

docs/content/code-review/_index.md

+4
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
---
2+
title: "Code review"
3+
weight: 50
4+
---

docs/content/contribute/create-pr.md renamed to docs/content/code-review/create-pr.md

+4-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
---
22
title: "Create a pull request"
33
weight: 10
4+
aliases:
5+
- /contribute/create-pr
46
---
57

68
# Create a pull request (PR)
@@ -12,7 +14,7 @@ weight: 10
1214
- If you are adding a few fields and also fixing a bug, create one PR for adding the new fields and a separate PR for the bugs.
1315
1. Follow the instructions at [Creating a pull request](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request) to create a pull request to merge your branch into `GoogleCloudPlatform/magic-modules`.
1416
- Make sure the PR body includes the text `Fixes GITHUB_ISSUE_LINK.` once per issue resolved by your PR. Replace `GITHUB_ISSUE_LINK` with a link to a GitHub issue from the [provider issue tracker](https://github.com/hashicorp/terraform-provider-google/issues).
15-
- [Write release notes]({{< ref "/contribute/release-notes" >}})
17+
- [Write release notes]({{< ref "/code-review/release-notes" >}})
1618

1719
## Code review
1820

@@ -28,7 +30,7 @@ weight: 10
2830
- You can push them and test in parallel as well. New CI runs will preempt old ones where possible.
2931
1. Resolve failed [status checks](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks) quickly
3032
- Directly ask your reviewer for help if you don't know how to proceed. If there are failed checks they may only check in if there's no progress after a couple days.
31-
1. [Self-review your PR]({{< ref "/contribute/review-pr" >}}) or ask someone else familiar with Terraform to review
33+
1. [Self-review your PR]({{< ref "/code-review/review-pr" >}}) or ask someone else familiar with Terraform to review
3234
{{< /hint >}}
3335

3436

docs/content/contribute/release-notes.md renamed to docs/content/code-review/release-notes.md

+2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
---
22
title: "Write release notes"
33
weight: 20
4+
aliases:
5+
- /contribute/release-notes
46
---
57

68
# Write release notes

docs/content/contribute/review-pr.md renamed to docs/content/code-review/review-pr.md

+2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
---
22
title: "Review a pull request"
33
weight: 30
4+
aliases:
5+
- /contribute/review-pr
46
---
57

68
# Review a pull request

docs/content/contribute/_index.md

-4
This file was deleted.

docs/content/contribution-process.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ This page explains how you can contribute code and documentation to the `magic-m
3232
+ [Make a breaking change]({{< ref "/breaking-changes/make-a-breaking-change" >}})
3333
1. [Generate the providers]({{< ref "/develop/generate-providers" >}}) that include your change.
3434
1. [Run provider tests locally]({{< ref "/test/run-tests" >}}) that are relevant to the change you made
35-
1. [Create a pull request (PR)]({{< ref "/contribute/create-pr" >}})
36-
1. Make changes in response to [code review]({{< ref "/contribute/create-pr#code-review" >}})
35+
1. [Create a pull request (PR)]({{< ref "/code-review/create-pr" >}})
36+
1. Make changes in response to [code review]({{< ref "/code-review/create-pr#code-review" >}})
3737

3838
## After your change is merged
3939

docs/content/test/run-tests.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -298,4 +298,4 @@ Terraform will resume its normal behaviour of pulling published provider version
298298
299299
## What's next?
300300

301-
[Create a pull request]({{< ref "/contribute/create-pr" >}})
301+
[Create a pull request]({{< ref "/code-review/create-pr" >}})

0 commit comments

Comments
 (0)