-
Notifications
You must be signed in to change notification settings - Fork 447
Chef 19: Drop filesystem2 #1872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I should probably do it, it was my baby ;) |
jaymzh
added a commit
to jaymzh/ohai
that referenced
this issue
Apr 16, 2025
In 2015, I wrote a new filesystem plugin (chef#559), because the original one used non-unique keys and so the data was not only incomplete but inconsistent. Since it was backwards incompatible, we called it `filesystem2`, and agreed to a migration path. That original PR only implemented it for linux, however, and it shortly followed with chef#564 for Darwin/OSX. The plan was, at that time to keep both for one major version (give people the chance to migrate to fs2), then for one major version make both names (`filesystem` and `filesystem2`) so that people could move back to the name `filesystem`, and then we'd finally drop the `filesystem2` name. Unfortunately, other platforms never got FS2 support, so this got hairy. In 2018 I wrote chef#181 which unified the various platforms' plugins so it was easier to implement fs2 on more platforms. Shortly there after I wrote chef#1266 that implemented fs2 for the rest of the unixes. And finally, I wrote chef#1267 implemented Windows to filesystem2. This was all still before Chef 17. For Chef 17 I wrote chef#1662 which finally made windows have the new data in the original name, the second-to-last-step. The plan being that in 18 we'd finally remove the `filesystem2` name... but we forgot to do that. This, is the final bit - remove all references to filesystem2. Closes chef#1872 Signed-off-by: Phil Dibowitz <[email protected]>
tpowell-progress
pushed a commit
to jaymzh/ohai
that referenced
this issue
Apr 22, 2025
In 2015, I wrote a new filesystem plugin (chef#559), because the original one used non-unique keys and so the data was not only incomplete but inconsistent. Since it was backwards incompatible, we called it `filesystem2`, and agreed to a migration path. That original PR only implemented it for linux, however, and it shortly followed with chef#564 for Darwin/OSX. The plan was, at that time to keep both for one major version (give people the chance to migrate to fs2), then for one major version make both names (`filesystem` and `filesystem2`) so that people could move back to the name `filesystem`, and then we'd finally drop the `filesystem2` name. Unfortunately, other platforms never got FS2 support, so this got hairy. In 2018 I wrote chef#181 which unified the various platforms' plugins so it was easier to implement fs2 on more platforms. Shortly there after I wrote chef#1266 that implemented fs2 for the rest of the unixes. And finally, I wrote chef#1267 implemented Windows to filesystem2. This was all still before Chef 17. For Chef 17 I wrote chef#1662 which finally made windows have the new data in the original name, the second-to-last-step. The plan being that in 18 we'd finally remove the `filesystem2` name... but we forgot to do that. This, is the final bit - remove all references to filesystem2. Closes chef#1872 Signed-off-by: Phil Dibowitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ohai/lib/ohai/plugins/filesystem.rb
Line 717 in f1396ac
@jaymzh lemme know if you want me to write the PR for removing remaining references to filesystem2.
The text was updated successfully, but these errors were encountered: