Skip to content

Commit 142b470

Browse files
chrisbobbegnprice
authored andcommitted
ios build: Address two Xcode deprecation warnings.
Part of the RN v0.61 -> v0.62 changes to the template app [1], corresponding to facebook/react-native@ebb629d05. These are warnings I think we've seen for a while (zulip#4112), and there's no suggestion that we can't do them before the main upgrade commit. The diff in the RN commit seems to address two warnings at the same time, even though only the "Missing Localizability" one is mentioned; like in that commit, we do them both here. They are: """ Migrate "English.lproj" (Deprecated) Migrating the English, deprecated localization to English is recommended for all projects. This will ensure localized resources are placed in “en.lproj” directories instead of deprecated “English.lproj” directories. """ """ Turn on "Missing Localizability" This will turn on the static analyzer check for "Missing Localizability", because this project is localized for multiple languages. """ The "Missing Localizability" change appears in the Upgrade Support repo's official guide for how to change the Xcode files using Xcode [2]; the "Migrate 'english.lproj' (Deprecated)" one does not. See also discussion on GitHub [3]. [1] https://react-native-community.github.io/upgrade-helper/?from=0.61.5&to=0.62.2 [2] react-native-community/upgrade-support#13 [3] zulip#4244 (comment)
1 parent 967e8ce commit 142b470

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

ios/ZulipMobile.xcodeproj/project.pbxproj

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@
175175
83CBB9F71A601CBA00E9B192 /* Project object */ = {
176176
isa = PBXProject;
177177
attributes = {
178-
LastUpgradeCheck = 940;
178+
LastUpgradeCheck = 1160;
179179
TargetAttributes = {
180180
13B07F861A680F5B00A75B9A = {
181181
DevelopmentTeam = 66KHCWMEYB;
@@ -194,10 +194,9 @@
194194
};
195195
buildConfigurationList = 83CBB9FA1A601CBA00E9B192 /* Build configuration list for PBXProject "ZulipMobile" */;
196196
compatibilityVersion = "Xcode 3.2";
197-
developmentRegion = English;
197+
developmentRegion = en;
198198
hasScannedForEncodings = 0;
199199
knownRegions = (
200-
English,
201200
en,
202201
Base,
203202
);
@@ -447,6 +446,7 @@
447446
isa = XCBuildConfiguration;
448447
buildSettings = {
449448
ALWAYS_SEARCH_USER_PATHS = NO;
449+
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
450450
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
451451
CLANG_CXX_LIBRARY = "libc++";
452452
CLANG_ENABLE_MODULES = YES;
@@ -502,6 +502,7 @@
502502
isa = XCBuildConfiguration;
503503
buildSettings = {
504504
ALWAYS_SEARCH_USER_PATHS = NO;
505+
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
505506
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
506507
CLANG_CXX_LIBRARY = "libc++";
507508
CLANG_ENABLE_MODULES = YES;

ios/ZulipMobile.xcodeproj/xcshareddata/xcschemes/ZulipMobile release-mode.xcscheme

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "0940"
3+
LastUpgradeVersion = "1160"
44
version = "1.3">
55
<BuildAction
66
parallelizeBuildables = "YES"

ios/ZulipMobile.xcodeproj/xcshareddata/xcschemes/ZulipMobile.xcscheme

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "0940"
3+
LastUpgradeVersion = "1160"
44
version = "1.3">
55
<BuildAction
66
parallelizeBuildables = "YES"

0 commit comments

Comments
 (0)