Skip to content

Fix functional tests that are failing in Entra ID/Defender #1688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task done
mitchelbaker-cisa opened this issue May 2, 2025 · 2 comments · May be fixed by #1694
Open
1 task done

Fix functional tests that are failing in Entra ID/Defender #1688

mitchelbaker-cisa opened this issue May 2, 2025 · 2 comments · May be fixed by #1694
Assignees
Labels
bug This issue or pull request addresses broken functionality
Milestone

Comments

@mitchelbaker-cisa
Copy link
Collaborator

mitchelbaker-cisa commented May 2, 2025

Prerequisites

  • This issue has an informative and human-readable title.

ScubaGear Version

v1.6 (latest main)

Operating System

Windows runner, windows-latest

PowerShell Version

5.1

M365 Environment and License(s)

gcc/gcc high/commercial

🐛 Summary

Entra ID functional tests are failing.

Image

Same issue with Defender.

Image

Steps to reproduce

  1. Look at functional test runs here: https://github.com/cisagov/ScubaGear/actions/workflows/test_production_function.yaml

Expected behavior

SetConditions should not throw an exception and all test plans should pass.

@mitchelbaker-cisa mitchelbaker-cisa added the bug This issue or pull request addresses broken functionality label May 2, 2025
@mitchelbaker-cisa mitchelbaker-cisa added this to the Nemo milestone May 2, 2025
@mitchelbaker-cisa mitchelbaker-cisa self-assigned this May 2, 2025
@mitchelbaker-cisa
Copy link
Collaborator Author

mitchelbaker-cisa commented May 9, 2025

We were originally accessing CAP settings with the following dot notation, GrantControls.AuthenticationStrength.AllowedCombinations which was causing Entra ID functional tests to fail. Changing them to the syntax below resolves remaining Entra ID test failures:

Image

@mitchelbaker-cisa
Copy link
Collaborator Author

Defender tests are failing because (Get-UnifiedGroup)[0].Alias assumes an array with at least one entry is returned. In some cases the commandlet does not return an array which results in a "Cannot index into a null array" error.

Image

Image

@mitchelbaker-cisa mitchelbaker-cisa linked a pull request May 9, 2025 that will close this issue
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant